From da2bc05cdc3acbaf2363e8a7dab96801dc70c33b Mon Sep 17 00:00:00 2001 From: Marco Beretta <81851188+berry-13@users.noreply.github.com> Date: Fri, 2 Oct 2026 23:18:18 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=92=AD=20fix:=20Show=20the=20Thoughts=20F?= =?UTF-8?q?loating=20Bar=20Only=20When=20Its=20Header=20Is=20Off=20Screen?= =?UTF-8?q?=20(#16642)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix: No Pressed Fill on the Thoughts Header * fix: Even Thoughts Padding and Show the Floating Bar Only When the Header Is Off Screen * fix: Re-measure the Thoughts Header on Every Visibility Notification * test: Scenarios for the Thoughts Floating Bar * test: Keep the Thoughts Scenarios to the Floating Bar --- .../Chat/Messages/Content/Parts/Reasoning.tsx | 25 ++-- .../Chat/Messages/Content/Parts/Thinking.tsx | 49 ++++++- .../scenarios/thoughts-floating-bar.spec.ts | 129 ++++++++++++++++++ eslint-suppressions.json | 2 +- 4 files changed, 189 insertions(+), 16 deletions(-) create mode 100644 e2e/specs/mock/scenarios/thoughts-floating-bar.spec.ts diff --git a/client/src/components/Chat/Messages/Content/Parts/Reasoning.tsx b/client/src/components/Chat/Messages/Content/Parts/Reasoning.tsx index 8d445e8281..a38aa582b3 100644 --- a/client/src/components/Chat/Messages/Content/Parts/Reasoning.tsx +++ b/client/src/components/Chat/Messages/Content/Parts/Reasoning.tsx @@ -162,7 +162,7 @@ const Reasoning = memo((props: ReasoningProps) => { const isExpanded = expansionOverride ?? defaultExpanded; const [isBarVisible, setIsBarVisible] = useState(false); const containerRef = useRef(null); - const { ref: headerRef, inViewport: headerInViewport } = useInViewport(); + const { ref: headerRef, inViewport: headerInViewport, recheck: recheckHeader } = useInViewport(); const { style: expandStyle, ref: expandRef } = useExpandCollapse(isExpanded); const { shouldRenderBody, mountBody, handleTransitionEnd } = useLazyCollapseBody(isExpanded); const { isSubmitting, isLatestMessage, nextType } = useMessage(); @@ -180,8 +180,9 @@ const Reasoning = memo((props: ReasoningProps) => { ); const handleFocus = useCallback(() => { + recheckHeader(); setIsBarVisible(true); - }, []); + }, [recheckHeader]); const handleBlur = useCallback((e: FocusEvent) => { if (!containerRef.current?.contains(e.relatedTarget as Node)) { @@ -190,8 +191,9 @@ const Reasoning = memo((props: ReasoningProps) => { }, []); const handleMouseEnter = useCallback(() => { + recheckHeader(); setIsBarVisible(true); - }, []); + }, [recheckHeader]); const handleMouseLeave = useCallback(() => { if (!containerRef.current?.contains(document.activeElement)) { @@ -318,7 +320,11 @@ export const ReasoningCompact = memo( const [isBarVisible, setIsBarVisible] = useState(false); const [isCopied, setIsCopied] = useState(false); const containerRef = useRef(null); - const { ref: headerRef, inViewport: headerInViewport } = useInViewport(); + const { + ref: headerRef, + inViewport: headerInViewport, + recheck: recheckHeader, + } = useInViewport(); const { style: expandStyle, ref: expandRef } = useExpandCollapse(isExpanded); /** Collapsed is the default whenever thoughts are hidden, and a streaming * THINK part re-renders on every delta. Keeping the full text mounted @@ -345,7 +351,10 @@ export const ReasoningCompact = memo( setTimeout(() => setIsCopied(false), 2000); }, [reasoningText]); - const revealBar = useCallback(() => setIsBarVisible(true), []); + const revealBar = useCallback(() => { + recheckHeader(); + setIsBarVisible(true); + }, [recheckHeader]); const hideBar = useCallback(() => { if (!containerRef.current?.contains(document.activeElement)) { setIsBarVisible(false); @@ -372,11 +381,11 @@ export const ReasoningCompact = memo( >