From d4a7f7472f672d1abd723a7d664b5347f47bc2ee Mon Sep 17 00:00:00 2001 From: tang-ontheway Date: Tue, 17 Nov 2026 06:45:00 +0800 Subject: [PATCH] =?UTF-8?q?=E2=86=95=EF=B8=8F=20fix:=20Enable=20Vertical?= =?UTF-8?q?=20Scrolling=20in=20Skill=20Dialogs=20(#18206)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../components/Skills/dialogs/CreateSkillDialog.tsx | 4 ++-- .../components/Skills/dialogs/UploadSkillDialog.tsx | 2 +- .../dialogs/__tests__/CreateSkillDialog.spec.tsx | 11 +++++++++++ 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/client/src/components/Skills/dialogs/CreateSkillDialog.tsx b/client/src/components/Skills/dialogs/CreateSkillDialog.tsx index 7a0601d82f..b293b4f765 100644 --- a/client/src/components/Skills/dialogs/CreateSkillDialog.tsx +++ b/client/src/components/Skills/dialogs/CreateSkillDialog.tsx @@ -162,7 +162,7 @@ export default function CreateSkillDialog({

{localize('com_ui_skill_write_instructions')} @@ -255,7 +255,7 @@ export default function CreateSkillDialog({ {/* Actions */} -
+
diff --git a/client/src/components/Skills/dialogs/UploadSkillDialog.tsx b/client/src/components/Skills/dialogs/UploadSkillDialog.tsx index 51ee456ea0..3b17095917 100644 --- a/client/src/components/Skills/dialogs/UploadSkillDialog.tsx +++ b/client/src/components/Skills/dialogs/UploadSkillDialog.tsx @@ -208,7 +208,7 @@ export default function UploadSkillDialog({ isOpen, setIsOpen }: UploadSkillDial }} > -
+

{localize('com_ui_skill_upload_title')}

diff --git a/client/src/components/Skills/dialogs/__tests__/CreateSkillDialog.spec.tsx b/client/src/components/Skills/dialogs/__tests__/CreateSkillDialog.spec.tsx index 82b4b0c48d..d92f1812cf 100644 --- a/client/src/components/Skills/dialogs/__tests__/CreateSkillDialog.spec.tsx +++ b/client/src/components/Skills/dialogs/__tests__/CreateSkillDialog.spec.tsx @@ -151,4 +151,15 @@ describe('CreateSkillDialog', () => { ); expect(handleAgentSubmit).not.toHaveBeenCalled(); }); + + it('enables vertical scrolling on the form container so footer buttons remain accessible', () => { + render(); + + const createButton = screen.getByRole('button', { name: 'Create' }); + const form = createButton.closest('form'); + + expect(form).not.toBeNull(); + expect(form).toHaveClass('max-h-[85vh]', 'overflow-y-auto'); + expect(form).not.toHaveClass('overflow-hidden'); + }); });