From cdf2e94dcf4cd7baa4ab0759031a37273d3a837a Mon Sep 17 00:00:00 2001 From: Marco Beretta <81851188+berry-13@users.noreply.github.com> Date: Wed, 7 Oct 2026 12:35:30 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=B1=20chore:=20Let=20Callers=20Own=20S?= =?UTF-8?q?pacing=20on=20Dialog=20and=20Panel=20Containers=20(#16836)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- eslint-suppressions.json | 84 +++++++++++++--------------------------- eslint.config.mjs | 13 ++++++- 2 files changed, 38 insertions(+), 59 deletions(-) diff --git a/eslint-suppressions.json b/eslint-suppressions.json index 2519e03c13..f8d8b91e99 100644 --- a/eslint-suppressions.json +++ b/eslint-suppressions.json @@ -14,7 +14,7 @@ "count": 4 }, "shadcn/no-restyle": { - "count": 16 + "count": 11 } }, "client/src/components/Agents/AgentGrid.tsx": { @@ -360,11 +360,6 @@ "count": 9 } }, - "client/src/components/Chat/Messages/Content/FilePreviewDialog.tsx": { - "shadcn/no-restyle": { - "count": 4 - } - }, "client/src/components/Chat/Messages/Content/Image.tsx": { "shadcn/no-inline-styles": { "count": 1 @@ -627,7 +622,7 @@ }, "client/src/components/Chat/Messages/Feedback.tsx": { "shadcn/no-restyle": { - "count": 17 + "count": 14 }, "shadcn/require-static-classes": { "count": 3 @@ -720,7 +715,7 @@ }, "client/src/components/Chat/Subagents/SharedSubagentActivityDialog.tsx": { "shadcn/no-restyle": { - "count": 9 + "count": 2 } }, "client/src/components/Chat/Subagents/SubagentActivity.tsx": { @@ -794,7 +789,7 @@ }, "client/src/components/Conversations/ConvoOptions/ShareButton.tsx": { "shadcn/no-restyle": { - "count": 10 + "count": 1 } }, "client/src/components/Conversations/ConvoOptions/SharedLinkCopyButton.tsx": { @@ -922,11 +917,6 @@ "count": 18 } }, - "client/src/components/MCP/MCPConfigDialog.tsx": { - "shadcn/no-restyle": { - "count": 2 - } - }, "client/src/components/MCP/MCPServerMenuItem.tsx": { "shadcn/no-restyle": { "count": 3 @@ -942,7 +932,7 @@ "count": 3 }, "shadcn/no-restyle": { - "count": 7 + "count": 3 } }, "client/src/components/MCP/StackedMCPIcons.tsx": { @@ -987,7 +977,7 @@ "count": 1 }, "shadcn/no-restyle": { - "count": 34 + "count": 30 } }, "client/src/components/Messages/Content/RunCode.tsx": { @@ -1018,7 +1008,7 @@ "count": 11 }, "shadcn/no-restyle": { - "count": 12 + "count": 9 } }, "client/src/components/Nav/NavToggle.tsx": { @@ -1033,22 +1023,22 @@ }, "client/src/components/Nav/SettingsTabs/Account/Avatar.tsx": { "shadcn/no-restyle": { - "count": 6 + "count": 3 } }, "client/src/components/Nav/SettingsTabs/Account/BackupCodesItem.tsx": { "shadcn/no-restyle": { - "count": 3 + "count": 1 } }, "client/src/components/Nav/SettingsTabs/Account/DeleteAccount.tsx": { "shadcn/no-restyle": { - "count": 17 + "count": 14 } }, "client/src/components/Nav/SettingsTabs/Account/TwoFactorAuthentication.tsx": { "shadcn/no-restyle": { - "count": 5 + "count": 2 } }, "client/src/components/Nav/SettingsTabs/Account/TwoFactorPhases/BackupPhase.tsx": { @@ -1078,7 +1068,7 @@ }, "client/src/components/Nav/SettingsTabs/ApiKeys/ApiKeys.tsx": { "shadcn/no-restyle": { - "count": 6 + "count": 4 } }, "client/src/components/Nav/SettingsTabs/ApiKeys/List.tsx": { @@ -1121,7 +1111,7 @@ }, "client/src/components/Nav/SettingsTabs/ProviderKeys/ProviderKeys.tsx": { "shadcn/no-restyle": { - "count": 8 + "count": 6 } }, "client/src/components/Nav/SettingsTabs/Speech/STT/AutoSendTextSelector.tsx": { @@ -1282,7 +1272,7 @@ }, "client/src/components/Prompts/sidebar/GroupSidePanel.tsx": { "shadcn/no-restyle": { - "count": 11 + "count": 7 } }, "client/src/components/Prompts/utils/SkeletonForm.tsx": { @@ -1307,12 +1297,12 @@ }, "client/src/components/SharePoint/SharePointPickerDialog.tsx": { "shadcn/no-restyle": { - "count": 5 + "count": 4 } }, "client/src/components/Sharing/GenericGrantAccessDialog.tsx": { "shadcn/no-restyle": { - "count": 17 + "count": 3 }, "shadcn/require-static-classes": { "count": 2 @@ -1338,7 +1328,7 @@ "count": 1 }, "shadcn/no-restyle": { - "count": 24 + "count": 18 } }, "client/src/components/SidePanel/Agents/ActionsTable/Columns.tsx": { @@ -1500,7 +1490,7 @@ }, "client/src/components/SidePanel/Agents/Tools/ItemDialog/ItemDialog.tsx": { "shadcn/no-restyle": { - "count": 3 + "count": 1 } }, "client/src/components/SidePanel/Agents/Tools/ItemDialog/ItemDialogHeader.tsx": { @@ -1508,7 +1498,7 @@ "count": 1 }, "shadcn/no-restyle": { - "count": 12 + "count": 1 } }, "client/src/components/SidePanel/Agents/Tools/ItemDialog/sections/McpSection.tsx": { @@ -1537,7 +1527,7 @@ }, "client/src/components/SidePanel/Agents/Tools/SkillsDialog.tsx": { "shadcn/no-restyle": { - "count": 10 + "count": 7 } }, "client/src/components/SidePanel/Agents/Tools/SkillsSection.tsx": { @@ -1560,7 +1550,7 @@ }, "client/src/components/SidePanel/Agents/Tools/ToolsMarketplaceDialog.tsx": { "shadcn/no-restyle": { - "count": 7 + "count": 6 } }, "client/src/components/SidePanel/Agents/Tools/ToolsSection.tsx": { @@ -1591,11 +1581,6 @@ "count": 2 } }, - "client/src/components/SidePanel/Bookmarks/BookmarkTable.tsx": { - "shadcn/no-restyle": { - "count": 2 - } - }, "client/src/components/SidePanel/Builder/Action.tsx": { "shadcn/no-inline-styles": { "count": 1 @@ -1608,7 +1593,7 @@ }, "client/src/components/SidePanel/Builder/ActionsAuth.tsx": { "shadcn/no-restyle": { - "count": 4 + "count": 2 } }, "client/src/components/SidePanel/Builder/AssistantConversationStarters.tsx": { @@ -1652,11 +1637,6 @@ "count": 1 } }, - "client/src/components/SidePanel/MCPBuilder/MCPBuilderPanel.tsx": { - "shadcn/no-restyle": { - "count": 2 - } - }, "client/src/components/SidePanel/MCPBuilder/MCPServerCard.tsx": { "shadcn/no-restyle": { "count": 3 @@ -1699,7 +1679,7 @@ }, "client/src/components/SidePanel/Memories/MemoryPanel.tsx": { "shadcn/no-restyle": { - "count": 4 + "count": 2 } }, "client/src/components/SidePanel/Parameters/DynamicCombobox.tsx": { @@ -1750,11 +1730,6 @@ "count": 14 } }, - "client/src/components/SidePanel/Schedules/SchedulePanel.tsx": { - "shadcn/no-restyle": { - "count": 2 - } - }, "client/src/components/Skills/buttons/ShareSkill.tsx": { "shadcn/no-restyle": { "count": 1 @@ -1815,11 +1790,6 @@ "count": 1 } }, - "client/src/components/Skills/sidebar/SkillsSidePanel.tsx": { - "shadcn/no-restyle": { - "count": 2 - } - }, "client/src/components/Skills/tree/SkillFileEditor.tsx": { "shadcn/no-arbitrary-values": { "count": 3 @@ -1841,7 +1811,7 @@ "count": 1 }, "shadcn/no-restyle": { - "count": 12 + "count": 6 } }, "client/src/components/Tools/ToolItem.tsx": { @@ -1879,7 +1849,7 @@ }, "client/src/components/Variables/Editor.tsx": { "shadcn/no-restyle": { - "count": 11 + "count": 6 }, "shadcn/require-static-classes": { "count": 1 @@ -1898,7 +1868,7 @@ "count": 1 }, "shadcn/no-restyle": { - "count": 50 + "count": 44 }, "shadcn/no-unknown-classes": { "count": 1 @@ -1906,7 +1876,7 @@ }, "client/src/components/ui/AdminSettingsDialog.tsx": { "shadcn/no-restyle": { - "count": 14 + "count": 3 }, "shadcn/require-static-classes": { "count": 1 diff --git a/eslint.config.mjs b/eslint.config.mjs index 9c9fd1c986..bb50529584 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -214,6 +214,9 @@ export default [ // `icon-*` is a sizing utility from client/src/style.css (height, width, stroke-width), // so it belongs with layout rather than with a primitive's own appearance. allow: ['layout', 'icon-*'], + // The lint names a component after its declaration in `packages/client/dist`, where the + // bundler suffixes a colliding name (`DialogContent$1`, from the two dialog families), so + // every pattern accepts that suffix. // A contract replaces `allow` rather than extending it, so each one restates the // baseline. These record policy, not debt: the categories below are the caller's to // set, which is why they are not in eslint-suppressions.json. @@ -221,12 +224,18 @@ export default [ // A text primitive renders the caller's text, so the caller owns its size, weight // and leading. Color is still the theme's: it stays reported here. { - pattern: '^(Label|Description|DialogTitle|DialogDescription|SeriesLabel)$', + pattern: '^(Label|Description|DialogTitle|DialogDescription|SeriesLabel)(\\$\\d+)?$', allow: ['layout', 'icon-*', 'typography'], }, // A skeleton stands in for the caller's content, so it takes that content's // silhouette and footprint. - { pattern: '^Skeleton$', allow: ['layout', 'icon-*', 'shape', 'spacing'] }, + { pattern: '^Skeleton(\\$\\d+)?$', allow: ['layout', 'icon-*', 'shape', 'spacing'] }, + // A dialog or panel container lays out whatever the caller puts in it, so the padding + // and gaps between those parts are the caller's. Color and shape stay the theme's. + { + pattern: '^(DialogContent|DialogHeader|DialogFooter|PanelContent)(\\$\\d+)?$', + allow: ['layout', 'icon-*', 'spacing'], + }, ], }, ],