From c6e5f98552c46de477651cf9db4e1885598ec4e1 Mon Sep 17 00:00:00 2001 From: Marco Beretta <81851188+berry-13@users.noreply.github.com> Date: Mon, 5 Oct 2026 12:47:22 +0200 Subject: [PATCH] =?UTF-8?q?=E2=9A=99=EF=B8=8F=20fix:=20Default=20Running?= =?UTF-8?q?=20Chat=20Rename=20to=20On=20(#16769)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit interface.runningChatRename now defaults to true, so a running chat or a placeholder-title chat can be renamed without a librechat.yaml override. Set it to false during a rolling upgrade from a version without title ownership. --- e2e/README.md | 8 +++---- librechat.example.yaml | 7 +++--- packages/data-provider/src/config.spec.ts | 12 ++++++---- packages/data-provider/src/config.ts | 6 ++--- .../data-schemas/src/app/interface.spec.ts | 23 ++++++++++--------- 5 files changed, 31 insertions(+), 25 deletions(-) diff --git a/e2e/README.md b/e2e/README.md index c741a51255..dc0592d5a3 100644 --- a/e2e/README.md +++ b/e2e/README.md @@ -217,10 +217,10 @@ Keep storage state, traces, logs, and session data private. Check that the PNGs ## Running-chat rename rollout -`interface.runningChatRename` defaults to `false`. Keep it off during rolling upgrades. -After **every API replica** supports title ownership, drain all title-generation tasks -started on older replicas, then enable it fleet-wide. The client also requires the -server's title-ownership capability; an old replica cannot advertise it. +`interface.runningChatRename` defaults to `true`. Set it to `false` during rolling upgrades +from a version without title ownership. After **every API replica** supports title ownership, +drain all title-generation tasks started on older replicas, then remove the override. The client +also requires the server's title-ownership capability; an old replica cannot advertise it. With the fence off, running rows and unowned placeholder titles cannot be renamed. Other menu actions remain available. Settled non-placeholder chats retain Rename. diff --git a/librechat.example.yaml b/librechat.example.yaml index b11190aae4..358374bcb0 100644 --- a/librechat.example.yaml +++ b/librechat.example.yaml @@ -155,10 +155,11 @@ projects: # Custom interface configuration interface: customWelcome: 'Welcome to LibreChat! Enjoy your experience.' - # After ALL API replicas are upgraded and old title-generation jobs have drained: + # Allow renaming a running chat or one with a placeholder title (default: true). + # Set to false during a rolling upgrade, until ALL API replicas are upgraded and old + # title-generation jobs have drained. While false, rename is disabled for running chats + # and unowned placeholder titles; other actions stay available. # runningChatRename: true - # Keep false (default) during rolling upgrades. Missing server capability disables - # rename for running chats and unowned placeholder titles; other actions stay available. # Minimum interval between syntax-highlighting passes while streamed code changes (default: 300 ms) # codeHighlightThrottleMs: 300 # How long a conversation's message history stays cached in the browser after leaving it (default: 60000 ms), diff --git a/packages/data-provider/src/config.spec.ts b/packages/data-provider/src/config.spec.ts index 3e193bbf38..77e232eff6 100644 --- a/packages/data-provider/src/config.spec.ts +++ b/packages/data-provider/src/config.spec.ts @@ -2575,10 +2575,14 @@ it.each([{ baseMs: 1 }, { maxMs: 600001 }, { baseMs: 1000, maxMs: 500 }])( ); describe('conversation title ownership rollout', () => { - it('defaults running rename off and accepts only an explicit deployment opt-in', () => { - expect(interfaceSchema.parse({}).runningChatRename).toBe(false); - expect(interfaceSchema.parse(undefined).runningChatRename).toBe(false); - expect(interfaceSchema.parse({ runningChatRename: true }).runningChatRename).toBe(true); + it('defaults running rename on when the option is omitted', () => { + expect(interfaceSchema.parse({}).runningChatRename).toBe(true); + }); + it('defaults running rename on when the whole interface block is omitted', () => { + expect(interfaceSchema.parse(undefined).runningChatRename).toBe(true); + }); + it('lets a deployment opt out of running rename explicitly', () => { + expect(interfaceSchema.parse({ runningChatRename: false }).runningChatRename).toBe(false); }); it('fails closed when an old replica omits the version or the operator leaves the fence off', () => { expect(supportsConversationTitleOwnership(undefined)).toBe(false); diff --git a/packages/data-provider/src/config.ts b/packages/data-provider/src/config.ts index 23e4709aeb..3a4e7d2500 100644 --- a/packages/data-provider/src/config.ts +++ b/packages/data-provider/src/config.ts @@ -2579,8 +2579,8 @@ export const interfaceSchema = z customWelcome: z.string().optional(), mcpServers: mcpServersSchema.optional(), modelSelect: z.boolean().optional(), - /** Enable only after every API replica supports title ownership and old title jobs drain. */ - runningChatRename: z.boolean().default(false), + /** Set to false during a rolling upgrade, until every API replica supports title ownership and old title jobs drain. */ + runningChatRename: z.boolean().default(true), /** Milliseconds between syntax highlights while a code block streams. */ codeHighlightThrottleMs: z.number().int().min(0).max(60_000).default(300), /** Most agents the agents panel selector lists before a search term is @@ -2828,7 +2828,7 @@ export const interfaceSchema = z }) .default({ modelSelect: true, - runningChatRename: false, + runningChatRename: true, codeHighlightThrottleMs: 300, agentSelectorLimit: DEFAULT_AGENT_SELECTOR_LIMIT, parameters: true, diff --git a/packages/data-schemas/src/app/interface.spec.ts b/packages/data-schemas/src/app/interface.spec.ts index 632b32e855..926841bb40 100644 --- a/packages/data-schemas/src/app/interface.spec.ts +++ b/packages/data-schemas/src/app/interface.spec.ts @@ -446,15 +446,16 @@ describe('loadDefaultInterface', () => { }); describe('running chat rename deployment fence', () => { - it.each([undefined, false, true])( - 'forwards operator opt-in without enabling it by default: %s', - async (enabled) => { - const configDefaults = getConfigDefaults(); - const interfaceConfig = await loadDefaultInterface({ - config: { interface: enabled === undefined ? {} : { runningChatRename: enabled } }, - configDefaults, - }); - expect(interfaceConfig?.runningChatRename).toBe(enabled === true); - }, - ); + it.each([ + [undefined, true], + [false, false], + [true, true], + ])('resolves runningChatRename %s to %s', async (configured, expected) => { + const configDefaults = getConfigDefaults(); + const interfaceConfig = await loadDefaultInterface({ + config: { interface: configured === undefined ? {} : { runningChatRename: configured } }, + configDefaults, + }); + expect(interfaceConfig?.runningChatRename).toBe(expected); + }); });