📐 fix: Align Composer Palette With Its Anchor (#18137)
Some checks are pending
Backend Unit Tests / Build packages (push) Waiting to run
Backend Unit Tests / Codegraph select (push) Waiting to run
Backend Unit Tests / TypeScript type checks (push) Blocked by required conditions
Backend Unit Tests / Circular dependency checks (push) Waiting to run
Backend Unit Tests / Tests: api (shard 1/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 2/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: api (shard 3/3) (push) Blocked by required conditions
Backend Unit Tests / Tests: data-provider (push) Blocked by required conditions
Backend Unit Tests / Tests: data-schemas (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 1/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 2/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 3/4) (push) Blocked by required conditions
Backend Unit Tests / Tests: @librechat/api (shard 4/4) (push) Blocked by required conditions
Backend Unit Tests / backend (push) Blocked by required conditions
Codegraph E2E Vote Gate / Gate (push) Waiting to run
Codegraph E2E Votes / vote (shard 1/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 10/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 2/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 3/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 4/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 5/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 6/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 7/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 8/10) (push) Waiting to run
Codegraph E2E Votes / vote (shard 9/10) (push) Waiting to run
Docker Dev Branch Images Build / publish (push) Waiting to run
Frontend Unit Tests / Client build recovery regression (push) Waiting to run
Frontend Unit Tests / Codegraph select (push) Waiting to run
Frontend Unit Tests / Build packages (push) Waiting to run
Frontend Unit Tests / TypeScript type checks (client) (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/chat (push) Blocked by required conditions
Frontend Unit Tests / Tests: @librechat/client (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 1/2) (push) Blocked by required conditions
Frontend Unit Tests / Tests: Ubuntu (shard 2/2) (push) Blocked by required conditions
Frontend Unit Tests / Vite build verification (push) Blocked by required conditions
Frontend Unit Tests / frontend (push) Blocked by required conditions
Playwright E2E Tests / Codegraph select (push) Waiting to run
Playwright E2E Tests / Shard timings (push) Waiting to run
Playwright E2E Tests / e2e () (push) Blocked by required conditions
Playwright E2E Tests / MCP list_changed (replica count 1) (push) Blocked by required conditions
Playwright E2E Tests / MCP list_changed (replica count 2) (push) Blocked by required conditions
Playwright E2E Tests / MCP Apps (browser and server) (push) Waiting to run
Playwright E2E Tests / e2e (push) Blocked by required conditions
Playwright Shard Timings / Record shard timings (push) Waiting to run

This commit is contained in:
Marco Beretta 2026-11-14 03:14:21 +01:00 • committed by GitHub
parent 34c0c3f025
commit ac15da03fa
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 26 additions and 3 deletions

View file

@ -55,8 +55,6 @@ const VIEWPORT_PADDING = 12;
/** Length of the landing screen's lift transition; see `ChatView`'s
* `duration-200` on the same element. */
const LIFT_MS = 200;
/** Ariakit portals to document.body by default, which puts the palette outside every landmark. */
const getMainLandmark = () => document.querySelector<HTMLElement>('main');
/** Hidden until the row is hovered or focused, wherever no pointer is coarse.
* Any touchscreen keeps them visible, including a 2-in-1's beside its hovering
* trackpad. `transition-none` overrides IconButton's color fade so the reveal
@ -1240,9 +1238,11 @@ function Palette({
/>
</Ariakit.PopoverDisclosure>
</span>
{/* Keep fixed positioning outside the main container query boundary.
Floating UI treats that boundary as a containing block and subtracts
its offset even in browsers where fixed elements use the viewport. */}
<Ariakit.Popover
portal
portalElement={getMainLandmark}
data-chat-pane-portal={index}
preserveTabOrder
fixed

View file

@ -146,6 +146,29 @@ async function uploadFile(
}
test.describe('composer palette show all', () => {
test('matches the composer bounds beside an expanded sidebar @scenario:palette-matches-composer-bounds', async ({
page,
}) => {
test.skip((page.viewportSize()?.width ?? 0) < 768, 'Desktop sidebar alignment');
await gotoMockChat(page);
await useMockEndpoint(page);
const openSidebar = page.getByTestId('open-sidebar-button');
if (await openSidebar.isVisible()) {
await openSidebar.click();
}
await expect(page.getByTestId('close-sidebar-button')).toBeVisible();
await openPalette(page);
await expect(async () => {
const composerBox = await page.getByTestId('composer-surface').boundingBox();
const paletteBox = await palette(page).boundingBox();
expect(composerBox).not.toBeNull();
expect(paletteBox).not.toBeNull();
expect(Math.abs(paletteBox!.x - composerBox!.x)).toBeLessThanOrEqual(2);
expect(Math.abs(paletteBox!.width - composerBox!.width)).toBeLessThanOrEqual(2);
}).toPass();
});
test('caps long sections with Show all and leaves Tools uncapped @scenario:palette-caps-long-sections-with-show-all', async ({
page,
}) => {