From 688296e13b8dc144a768085f674a6836f28eb4eb Mon Sep 17 00:00:00 2001 From: Danny Avila Date: Wed, 11 Mar 2026 21:48:07 -0400 Subject: [PATCH] refactor(tests): simplify event handler setup in createResponse tests Removed redundant mock implementations for event handlers in the createResponse unit tests, streamlining the setup process. This change enhances test clarity and maintainability while ensuring that the tests continue to validate the correct behavior of usage tracking during on_chat_model_end events. --- .../agents/__tests__/responses.unit.spec.js | 22 ------------------- 1 file changed, 22 deletions(-) diff --git a/api/server/controllers/agents/__tests__/responses.unit.spec.js b/api/server/controllers/agents/__tests__/responses.unit.spec.js index b3b828966a..a3c99b4b01 100644 --- a/api/server/controllers/agents/__tests__/responses.unit.spec.js +++ b/api/server/controllers/agents/__tests__/responses.unit.spec.js @@ -275,28 +275,7 @@ describe('createResponse controller', () => { it('should collect usage from on_chat_model_end events', async () => { const api = require('@librechat/api'); - let capturedOnChatModelEnd; - api.createAggregatorEventHandlers.mockImplementation(() => { - return { - on_message_delta: { handle: jest.fn() }, - on_reasoning_delta: { handle: jest.fn() }, - on_run_step: { handle: jest.fn() }, - on_run_step_delta: { handle: jest.fn() }, - on_chat_model_end: { - handle: jest.fn((event, data) => { - if (capturedOnChatModelEnd) { - capturedOnChatModelEnd(event, data); - } - }), - }, - }; - }); - api.createRun.mockImplementation(async ({ customHandlers }) => { - capturedOnChatModelEnd = (event, data) => { - customHandlers.on_chat_model_end.handle(event, data); - }; - return { processStream: jest.fn().mockImplementation(async () => { customHandlers.on_chat_model_end.handle('on_chat_model_end', { @@ -313,7 +292,6 @@ describe('createResponse controller', () => { }); await createResponse(req, res); - expect(mockRecordCollectedUsage).toHaveBeenCalledWith( expect.any(Object), expect.objectContaining({