CERBERUS/LibreChat
1
0
Fork 0
mirror of https://github.com/danny-avila/LibreChat.git synced 2026-10-24 11:12:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

test(client): pin both web-search rows to the shared glyph rail

Browse source 
The rebase onto dev silently dropped `ROW_GLYPH_SLOT` from the completed
row — its glyph had since moved inside a shared `Button` — and left the
streaming row on a 10px gap, so nothing caught either. `Part.tsx` routes
web search past `ProgressText`, so this renderer owns its glyph and has
to take the slot itself; the test fails on both regressions.
This commit is contained in:
Marco Beretta 2026-09-06 18:54:14 +02:00
parent 77e905be2c
commit 638a55635c
No known key found for this signature in database
GPG key ID: D918033D8E74CC11
1 changed files with 30 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

30
client/src/components/Chat/Messages/Content/__tests__/WebSearch.test.tsx
View file

@ -4,6 +4,7 @@ import { Tools } from 'librechat-data-provider';
import { fireEvent, render, screen } from '@testing-library/react';
import type { TAttachment, SearchResultData, ValidSource } from 'librechat-data-provider';
import { SearchContext } from '~/Providers';
import { ROW_GLYPH_SLOT } from '../rows';
import WebSearch from '../WebSearch';
jest.mock('~/hooks', () => ({
@ -452,6 +453,35 @@ describe('WebSearch', () => {
expect(chevron.className).not.toContain('transition-opacity');
});
it('puts both rows glyph on the shared row rail', () => {
/** `Part.tsx` routes web search past `ProgressText`, so this renderer
* draws its own glyph and has to take the shared slot itself or its
* favicon stack sits left of every other row under the header. */
const searchResults = makeSearchResults({
0: { organic: [makeSource('https://example.com', 'Example')] },
});
const { unmount } = renderWebSearch({ searchResults });
const completedRow = screen.getByRole('button', { name: /Searched the web/ });
const completedSlot = completedRow.firstElementChild;
expect(completedSlot).toContainElement(screen.getByTestId('favicon'));
for (const token of ROW_GLYPH_SLOT.split(' ')) {
expect(completedSlot).toHaveClass(token);
}
unmount();
renderWebSearch({ isSubmitting: true, isLast: true, initialProgress: 0.5 });
const streamingSlot = screen.getByTestId('globe-icon').parentElement;
for (const token of ROW_GLYPH_SLOT.split(' ')) {
expect(streamingSlot).toHaveClass(token);
}
/** 24px slot plus an 8px gap puts the label where the header's name
* starts; 10px would leave the streaming row 2px off the rail. */
expect(streamingSlot?.parentElement).toHaveClass('gap-2');
});
it('renders searching state during streaming', () => {
renderWebSearch({
isSubmitting: true,