mirror of
https://github.com/danny-avila/LibreChat.git
synced 2026-11-20 23:13:35 +00:00
🛫 feat: Enable Full Access for BYOM Coding (#15718)
* feat: Enable Full Access for BYOM Coding 🛫
* test: Preserve endpoint policy under Full Access
* fix: Gate Full Access on expected root agent metadata
This commit is contained in:
parent
cdc3339a78
commit
5ca1093ed9
16 changed files with 368 additions and 29 deletions
|
|
@ -97,7 +97,7 @@ describe('conversation code approval constraints', () => {
|
|||
).toEqual(['ask']);
|
||||
});
|
||||
|
||||
test.each(['autoApprove', 'bypass', 'fullAccess', '', {}, ['ask'], true, 1])(
|
||||
test.each(['autoApprove', 'bypass', 'invalidMode', '', {}, ['ask'], true, 1])(
|
||||
'rejects invalid request state: %j',
|
||||
(value) => {
|
||||
expect(() => resolveCodeApprovalMode(value, constraints)).toThrow(CodeApprovalModeError);
|
||||
|
|
@ -107,7 +107,7 @@ describe('conversation code approval constraints', () => {
|
|||
test('rejects an unvalidated runtime mode before permission lookup', () => {
|
||||
expect(() =>
|
||||
resolveCodePermissionDecision({
|
||||
mode: 'fullAccess' as never,
|
||||
mode: 'invalidMode' as never,
|
||||
category: 'fileWrite',
|
||||
decision: 'ask',
|
||||
}),
|
||||
|
|
@ -127,6 +127,24 @@ describe('conversation code approval constraints', () => {
|
|||
}
|
||||
});
|
||||
|
||||
test('full access allows commands and file writes only with both machine grants', () => {
|
||||
const mode = resolveCodeApprovalMode('fullAccess', constraints);
|
||||
for (const category of ['fileWrite', 'commandExecution'] as const) {
|
||||
expect(resolveCodePermissionDecision({ mode, category, decision: 'ask' })).toBe('allow');
|
||||
expect(() =>
|
||||
resolveCodeApprovalMode('fullAccess', {
|
||||
...constraints,
|
||||
configSchema: {
|
||||
permissions: {
|
||||
...constraints.configSchema?.permissions,
|
||||
[category]: { allowed: ['ask'], default: 'ask' },
|
||||
},
|
||||
},
|
||||
}),
|
||||
).toThrow(CodeApprovalModeError);
|
||||
}
|
||||
});
|
||||
|
||||
test('accept edits asks for commands and does not mutate its input', () => {
|
||||
const before = JSON.stringify(constraints);
|
||||
const mode = resolveCodeApprovalMode('acceptEdits', constraints);
|
||||
|
|
|
|||
|
|
@ -4,7 +4,7 @@ import type {
|
|||
CodeEnvironmentUserSettings,
|
||||
} from '../config';
|
||||
|
||||
export const CODE_APPROVAL_MODES = ['ask', 'acceptEdits'] as const;
|
||||
export const CODE_APPROVAL_MODES = ['ask', 'acceptEdits', 'fullAccess'] as const;
|
||||
export type CodeApprovalMode = (typeof CODE_APPROVAL_MODES)[number];
|
||||
|
||||
type CodePermissions = Required<NonNullable<CodeEnvironmentUserSettings['permissions']>>;
|
||||
|
|
@ -12,6 +12,7 @@ type CodePermissions = Required<NonNullable<CodeEnvironmentUserSettings['permiss
|
|||
const MODE_PERMISSIONS: Record<CodeApprovalMode, CodePermissions> = {
|
||||
ask: { fileWrite: 'ask', commandExecution: 'ask' },
|
||||
acceptEdits: { fileWrite: 'allow', commandExecution: 'ask' },
|
||||
fullAccess: { fileWrite: 'allow', commandExecution: 'allow' },
|
||||
};
|
||||
|
||||
export type CodeApprovalConstraints = {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue