diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 5d5454e97b..68f64289ac 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -1,4 +1,4 @@ -FROM node:24.16.0-bullseye +FROM node:24.22.1-bookworm RUN useradd -m -s /bin/bash vscode RUN mkdir -p /workspaces && chown -R vscode:vscode /workspaces diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index b393aee5cb..3aee3ba218 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -63,7 +63,7 @@ Project maintainers have the right and responsibility to remove, edit, or reject ## 1. Development Setup -1. Use Node.js v24.16.0. +1. Use Node.js v24.22.1. 2. Run `npm run smart-reinstall` to install dependencies (uses Turborepo). Use `npm run reinstall` for a clean install, or `npm ci` for a fresh lockfile-based install. 3. Build all compiled code: `npm run build`. 4. Setup and run unit tests: diff --git a/.github/playwright.yml b/.github/playwright.yml index 142d99b881..d204dcca0e 100644 --- a/.github/playwright.yml +++ b/.github/playwright.yml @@ -39,7 +39,7 @@ # - uses: actions/checkout@v5 # - uses: actions/setup-node@v5 # with: -# node-version: 24.16.0 +# node-version: 24.22.1 # cache: 'npm' # - name: Install global dependencies diff --git a/.github/workflows/agents-integration-tests.yml b/.github/workflows/agents-integration-tests.yml index f015ee618a..1ef6050e4e 100644 --- a/.github/workflows/agents-integration-tests.yml +++ b/.github/workflows/agents-integration-tests.yml @@ -55,10 +55,10 @@ jobs: - name: Checkout repository uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -70,7 +70,7 @@ jobs: packages/api/node_modules packages/data-provider/node_modules packages/data-schemas/node_modules - key: node-modules-backend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-backend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' diff --git a/.github/workflows/backend-review.yml b/.github/workflows/backend-review.yml index 3eed993d48..ce4c2a5c11 100644 --- a/.github/workflows/backend-review.yml +++ b/.github/workflows/backend-review.yml @@ -53,10 +53,10 @@ jobs: steps: - uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -68,7 +68,7 @@ jobs: packages/api/node_modules packages/data-provider/node_modules packages/data-schemas/node_modules - key: node-modules-backend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-backend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' @@ -262,10 +262,10 @@ jobs: steps: - uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -277,7 +277,7 @@ jobs: packages/api/node_modules packages/data-provider/node_modules packages/data-schemas/node_modules - key: node-modules-backend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-backend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' @@ -331,10 +331,10 @@ jobs: steps: - uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -346,7 +346,7 @@ jobs: packages/api/node_modules packages/data-provider/node_modules packages/data-schemas/node_modules - key: node-modules-backend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-backend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' @@ -377,10 +377,10 @@ jobs: steps: - uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -392,7 +392,7 @@ jobs: packages/api/node_modules packages/data-provider/node_modules packages/data-schemas/node_modules - key: node-modules-backend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-backend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' @@ -487,10 +487,10 @@ jobs: steps: - uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -502,7 +502,7 @@ jobs: packages/api/node_modules packages/data-provider/node_modules packages/data-schemas/node_modules - key: node-modules-backend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-backend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' @@ -572,10 +572,10 @@ jobs: steps: - uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -587,7 +587,7 @@ jobs: packages/api/node_modules packages/data-provider/node_modules packages/data-schemas/node_modules - key: node-modules-backend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-backend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' @@ -671,10 +671,10 @@ jobs: steps: - uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -686,7 +686,7 @@ jobs: packages/api/node_modules packages/data-provider/node_modules packages/data-schemas/node_modules - key: node-modules-backend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-backend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' diff --git a/.github/workflows/cache-integration-tests.yml b/.github/workflows/cache-integration-tests.yml index 9634569cf5..260638f213 100644 --- a/.github/workflows/cache-integration-tests.yml +++ b/.github/workflows/cache-integration-tests.yml @@ -39,10 +39,10 @@ jobs: - name: Checkout repository uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Install Redis tools timeout-minutes: 10 @@ -97,7 +97,7 @@ jobs: packages/api/node_modules packages/data-provider/node_modules packages/data-schemas/node_modules - key: node-modules-backend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-backend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' diff --git a/.github/workflows/client.yml b/.github/workflows/client.yml index 5cf3aad957..665ebdabaf 100644 --- a/.github/workflows/client.yml +++ b/.github/workflows/client.yml @@ -27,7 +27,7 @@ jobs: - name: Use Node.js uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Install client dependencies run: cd packages/client && npm ci @@ -77,7 +77,7 @@ jobs: - name: Use Node.js uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' registry-url: 'https://registry.npmjs.org' - name: Install npm with OIDC support diff --git a/.github/workflows/codegraph-e2e-votes.yml b/.github/workflows/codegraph-e2e-votes.yml index 1b976b530a..0666338148 100644 --- a/.github/workflows/codegraph-e2e-votes.yml +++ b/.github/workflows/codegraph-e2e-votes.yml @@ -57,10 +57,10 @@ jobs: steps: - uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -75,7 +75,7 @@ jobs: packages/data-schemas/node_modules packages/api/node_modules api/node_modules - key: node-modules-e2e-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-e2e-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' diff --git a/.github/workflows/data-provider.yml b/.github/workflows/data-provider.yml index 65cda55297..c3aed18863 100644 --- a/.github/workflows/data-provider.yml +++ b/.github/workflows/data-provider.yml @@ -23,7 +23,7 @@ jobs: - uses: actions/checkout@v5 - uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - run: cd packages/data-provider && npm ci - run: cd packages/data-provider && npm run build - name: Pack package @@ -50,7 +50,7 @@ jobs: steps: - uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' registry-url: 'https://registry.npmjs.org' - name: Install npm with OIDC support diff --git a/.github/workflows/data-schemas.yml b/.github/workflows/data-schemas.yml index 18d0dc7cc5..5c089ae0f1 100644 --- a/.github/workflows/data-schemas.yml +++ b/.github/workflows/data-schemas.yml @@ -27,7 +27,7 @@ jobs: - name: Use Node.js uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Install dependencies run: cd packages/data-schemas && npm ci @@ -77,7 +77,7 @@ jobs: - name: Use Node.js uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' registry-url: 'https://registry.npmjs.org' - name: Install npm with OIDC support diff --git a/.github/workflows/frontend-review.yml b/.github/workflows/frontend-review.yml index a1075e1039..d8218e0d0b 100644 --- a/.github/workflows/frontend-review.yml +++ b/.github/workflows/frontend-review.yml @@ -56,7 +56,7 @@ jobs: - uses: actions/checkout@v5 - uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' cache: npm - run: npm ci - run: google-chrome --version @@ -170,10 +170,10 @@ jobs: steps: - uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -185,7 +185,7 @@ jobs: packages/client/node_modules packages/chat/node_modules packages/data-provider/node_modules - key: node-modules-frontend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-frontend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' @@ -247,10 +247,10 @@ jobs: steps: - uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -262,7 +262,7 @@ jobs: packages/client/node_modules packages/chat/node_modules packages/data-provider/node_modules - key: node-modules-frontend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-frontend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' @@ -304,10 +304,10 @@ jobs: steps: - uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -319,7 +319,7 @@ jobs: packages/client/node_modules packages/chat/node_modules packages/data-provider/node_modules - key: node-modules-frontend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-frontend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' @@ -361,10 +361,10 @@ jobs: steps: - uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -376,7 +376,7 @@ jobs: packages/client/node_modules packages/chat/node_modules packages/data-provider/node_modules - key: node-modules-frontend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-frontend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' @@ -444,10 +444,10 @@ jobs: steps: - uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -459,7 +459,7 @@ jobs: packages/client/node_modules packages/chat/node_modules packages/data-provider/node_modules - key: node-modules-frontend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-frontend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' @@ -527,10 +527,10 @@ jobs: steps: - uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -542,7 +542,7 @@ jobs: packages/client/node_modules packages/chat/node_modules packages/data-provider/node_modules - key: node-modules-frontend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-frontend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' diff --git a/.github/workflows/frontend-windows-nightly.yml b/.github/workflows/frontend-windows-nightly.yml index d08cccea5c..0ca8401f59 100644 --- a/.github/workflows/frontend-windows-nightly.yml +++ b/.github/workflows/frontend-windows-nightly.yml @@ -32,10 +32,10 @@ jobs: shell: bash run: echo "sha=$(git rev-parse HEAD)" >> "$GITHUB_OUTPUT" - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -47,7 +47,7 @@ jobs: packages/client/node_modules packages/chat/node_modules packages/data-provider/node_modules - key: node-modules-frontend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-frontend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' @@ -113,10 +113,10 @@ jobs: with: ref: ${{ needs.build.outputs.source-sha }} - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -128,7 +128,7 @@ jobs: packages/client/node_modules packages/chat/node_modules packages/data-provider/node_modules - key: node-modules-frontend-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-frontend-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' diff --git a/.github/workflows/lighthouse.yml b/.github/workflows/lighthouse.yml index ea06ef2756..a7e7c638a9 100644 --- a/.github/workflows/lighthouse.yml +++ b/.github/workflows/lighthouse.yml @@ -32,7 +32,7 @@ jobs: - uses: actions/checkout@v5 - uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' cache: npm - run: npm ci - run: npm run e2e:prepare diff --git a/.github/workflows/locize-i18n-sync.yml b/.github/workflows/locize-i18n-sync.yml index 9798de22cb..a800bf10c9 100644 --- a/.github/workflows/locize-i18n-sync.yml +++ b/.github/workflows/locize-i18n-sync.yml @@ -29,7 +29,7 @@ jobs: - name: Set Up Node.js uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Install locize CLI run: npm install -g locize-cli@12.2.0 --ignore-scripts --no-audit --no-fund diff --git a/.github/workflows/playwright-bombadil.yml b/.github/workflows/playwright-bombadil.yml index 1c4b61d165..7eed3ab9dd 100644 --- a/.github/workflows/playwright-bombadil.yml +++ b/.github/workflows/playwright-bombadil.yml @@ -41,10 +41,10 @@ jobs: steps: - uses: actions/checkout@v4 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v4 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -59,7 +59,7 @@ jobs: packages/data-schemas/node_modules packages/api/node_modules api/node_modules - key: node-modules-e2e-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-e2e-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' diff --git a/.github/workflows/playwright-mock.yml b/.github/workflows/playwright-mock.yml index 10085c52f0..59aef8185a 100644 --- a/.github/workflows/playwright-mock.yml +++ b/.github/workflows/playwright-mock.yml @@ -198,10 +198,10 @@ jobs: steps: - uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -216,7 +216,7 @@ jobs: packages/data-schemas/node_modules packages/api/node_modules api/node_modules - key: node-modules-e2e-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-e2e-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' @@ -455,10 +455,10 @@ jobs: steps: - uses: actions/checkout@v4 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v4 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -473,7 +473,7 @@ jobs: packages/data-schemas/node_modules packages/api/node_modules api/node_modules - key: node-modules-e2e-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-e2e-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' @@ -602,10 +602,10 @@ jobs: steps: - uses: actions/checkout@v5 - - name: Use Node.js 24.16.0 + - name: Use Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' - name: Restore node_modules cache id: cache-node-modules @@ -620,7 +620,7 @@ jobs: packages/data-schemas/node_modules packages/api/node_modules api/node_modules - key: node-modules-e2e-${{ runner.os }}-24.16.0-${{ hashFiles('package-lock.json') }} + key: node-modules-e2e-${{ runner.os }}-24.22.1-${{ hashFiles('package-lock.json') }} - name: Install dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' diff --git a/.github/workflows/static-checks.yml b/.github/workflows/static-checks.yml index 70728b999b..77aebda19a 100644 --- a/.github/workflows/static-checks.yml +++ b/.github/workflows/static-checks.yml @@ -150,10 +150,10 @@ jobs: - '.github/workflows/static-checks.yml' - '!**.md' - - name: Set up Node.js 24.16.0 + - name: Set up Node.js 24.22.1 uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' cache: npm - name: Install dependencies @@ -813,11 +813,11 @@ jobs: - 'scripts/eslint/**' - '.github/workflows/static-checks.yml' - - name: Set up Node.js 24.16.0 + - name: Set up Node.js 24.22.1 if: steps.paths.outputs.eslint_config == 'true' uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' cache: npm - name: Install dependencies diff --git a/.github/workflows/workspace-acceptance.yml b/.github/workflows/workspace-acceptance.yml index 9cac759e7d..4aff1df3f4 100644 --- a/.github/workflows/workspace-acceptance.yml +++ b/.github/workflows/workspace-acceptance.yml @@ -39,7 +39,7 @@ jobs: - uses: actions/setup-node@v5 with: - node-version: '24.16.0' + node-version: '24.22.1' cache: npm - name: Install native prerequisites diff --git a/.nvmrc b/.nvmrc index b832e4001d..ce62013c39 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -24.16.0 +24.22.1 diff --git a/Dockerfile b/Dockerfile index 7a9e6e80bb..c56ee8698a 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,7 +1,7 @@ # v0.8.8 # Base node image -FROM node:24.16.0-alpine AS node +FROM node:24.22.1-alpine AS node RUN apk upgrade --no-cache RUN apk add --no-cache bash jemalloc diff --git a/Dockerfile.multi b/Dockerfile.multi index 712640eace..f2617a5a58 100644 --- a/Dockerfile.multi +++ b/Dockerfile.multi @@ -10,7 +10,7 @@ ARG BUILD_BRANCH= ARG BUILD_DATE= # Base for all builds -FROM node:24.16.0-alpine AS base-min +FROM node:24.22.1-alpine AS base-min ARG NPM_CI_TIMEOUT_SECONDS=1500 ARG NPM_CI_ATTEMPTS=2 RUN apk upgrade --no-cache diff --git a/e2e/byom/browser.mjs b/e2e/byom/browser.mjs new file mode 100644 index 0000000000..a5aeebf4c1 --- /dev/null +++ b/e2e/byom/browser.mjs @@ -0,0 +1,4 @@ +/** Native acceptance sends turns with Enter, including after reloads. */ +export function initializeBrowser() { + localStorage.setItem('enterToSend', 'true'); +} diff --git a/e2e/byom/browser.test.mjs b/e2e/byom/browser.test.mjs new file mode 100644 index 0000000000..6f493a6bf4 --- /dev/null +++ b/e2e/byom/browser.test.mjs @@ -0,0 +1,33 @@ +import test from 'node:test'; +import { runInNewContext } from 'node:vm'; +import assert from 'node:assert/strict'; +import { initializeBrowser } from './browser.mjs'; +import { resolveComposerKeyDown } from '../../client/src/utils/shortcuts.ts'; + +const enter = { key: 'Enter', ctrlKey: false, metaKey: false, altKey: false, shiftKey: false }; +const context = { + isComposing: false, + isSubmitting: false, + allowSubmitWhileGenerating: false, + hasDuringRunModifier: false, + shortcutsEnabled: true, + submitOverride: undefined, + yieldedChords: new Set(), +}; + +test('native acceptance opts into Enter submission before navigation and after reload', () => { + const values = new Map(); + const localStorage = { setItem: (key, value) => values.set(key, value) }; + const action = () => + resolveComposerKeyDown(enter, { + ...context, + enterToSend: JSON.parse(values.get('enterToSend') ?? 'false'), + }); + + assert.equal(action(), 'newline'); + for (let navigation = 0; navigation < 2; navigation++) { + runInNewContext(`(${initializeBrowser.toString()})()`, { localStorage }); + assert.equal(values.get('enterToSend'), 'true'); + assert.equal(action(), 'submit'); + } +}); diff --git a/e2e/byom/native.spec.ts b/e2e/byom/native.spec.ts index 8613ff8d9d..8d54666f18 100644 --- a/e2e/byom/native.spec.ts +++ b/e2e/byom/native.spec.ts @@ -4,6 +4,7 @@ import { spawn } from 'node:child_process'; import { mkdir, open, readFile, readdir } from 'node:fs/promises'; import { expect, test } from '@playwright/test'; import type { ChildProcess } from 'node:child_process'; +import { initializeBrowser } from './browser.mjs'; import { readGenerationStatus } from './status.mjs'; import { getAccessToken, @@ -43,6 +44,7 @@ async function stop(child: ChildProcess) { test('native BYOM saves, persists, isolates workers, and fails closed', async ({ page, }, testInfo) => { + await page.context().addInitScript(initializeBrowser); const runDir = process.env.BYOM_ACCEPTANCE_DIR!; const cli = process.env.BYOM_CODE_CLI!; const workspaceTransitions = process.env.BYOM_WORKSPACE_TRANSITIONS === 'true'; @@ -463,14 +465,14 @@ test('native BYOM saves, persists, isolates workers, and fails closed', async ({ expect(updated.code_environment_id).toBe(a.environmentId); expect(updated.code_environment_ids).toEqual([b.environmentId]); await page.goto(`/c/new?agent_id=${encodeURIComponent(coding.id)}`); - await expect(page.getByTestId('code-workspace')).toContainText('Acceptance a'); - await page.getByTestId('code-workspace').click(); + await expect(page.getByTestId('code-machine')).toContainText('Acceptance a'); + await page.getByTestId('code-machine').click(); await page.getByRole('menuitem', { name: 'Acceptance b', exact: true }).click(); await page .locator(`[data-code-environment-id="${b.environmentId}"]`) .getByRole('menuitemradio', { name: /workspace/ }) .click(); - await expect(page.getByTestId('code-workspace')).toContainText('Acceptance b'); + await expect(page.getByTestId('code-machine')).toContainText('Acceptance b'); selectedWorker = b; expect(await turn('read')).toContain('native-original'); const runtimeChat = new URL(page.url()).pathname.slice(3); @@ -483,7 +485,7 @@ test('native BYOM saves, persists, isolates workers, and fails closed', async ({ ]); expect(await turn('read')).toContain('native-original'); await page.goto(`/c/new?agent_id=${encodeURIComponent(coding.id)}`); - await expect(page.getByTestId('code-workspace')).toContainText('Acceptance a'); + await expect(page.getByTestId('code-machine')).toContainText('Acceptance a'); selectedWorker = a; expect(await turn('read')).toContain('native-edited'); const applicationChat = new URL(page.url()).pathname.slice(3); @@ -514,7 +516,7 @@ test('native BYOM saves, persists, isolates workers, and fails closed', async ({ body: { subagents: { enabled: true, allowSelf: false, agent_ids: [reviewer.id] } }, }); await page.goto(`/c/new?agent_id=${encodeURIComponent(coding.id)}`); - await page.getByTestId('code-workspace').click(); + await page.getByTestId('code-machine').click(); await page.getByRole('menuitem', { name: 'Acceptance b', exact: true }).click(); await page .locator(`[data-code-environment-id="${b.environmentId}"]`)