From 49ecc0695bdc61225e2b2bc6516bc4b2465ed010 Mon Sep 17 00:00:00 2001 From: Marco Beretta <81851188+berry-13@users.noreply.github.com> Date: Sun, 1 Nov 2026 01:23:47 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=B9=20chore:=20Clear=20the=20Whole-Rep?= =?UTF-8?q?o=20Lint=20Errors=20on=20Dev=20(#17702)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- api/server/routes/search.js | 2 +- api/test/__mocks__/openid-client.js | 2 +- client/babel.config.cjs | 6 +-- .../components/Chat/Input/TextareaHeader.tsx | 2 +- .../Endpoints/components/SpecDescription.tsx | 4 +- .../Chat/Menus/UI/MenuSeparator.tsx | 2 +- .../Chat/Messages/Content/MemoryInfo.tsx | 10 ++--- .../Endpoints/Settings/OptionHover.tsx | 2 +- .../Input/SetKeyDialog/HelpText.tsx | 4 +- client/src/components/MCP/MCPConfigDialog.tsx | 12 +++--- .../MCPUIResource/MCPUIResource.tsx | 4 +- .../Messages/Content/Mermaid/ZoomControls.tsx | 10 ++--- .../components/Nav/Settings/MemoryToggle.tsx | 2 +- .../Nav/SettingsTabs/ApiKeys/Admin.tsx | 2 +- .../Nav/SettingsTabs/ApiKeys/Create.tsx | 4 +- .../Nav/SettingsTabs/ApiKeys/Reveal.tsx | 6 +-- .../ProviderKeys/ProviderKeyRow.tsx | 4 +- .../Plugins/Store/PluginTooltip.tsx | 2 +- .../Prompts/lists/NoPromptGroup.tsx | 4 +- .../Agents/Advanced/AgentSubagents.tsx | 12 +++--- .../SidePanel/Agents/DuplicateAgent.tsx | 2 +- .../SidePanel/Agents/SectionHeader.tsx | 6 +-- .../ItemDialog/sections/SkillSection.tsx | 10 ++--- .../sections/ConnectionSection.tsx | 6 +-- client/src/components/SidePanel/Nav.tsx | 2 +- client/src/components/SidePanel/data.tsx | 38 ------------------- .../components/Skills/buttons/ShareSkill.tsx | 2 +- .../components/Skills/display/SkillDetail.tsx | 20 +++++----- .../Skills/display/SkillDetailHeader.tsx | 12 +++--- .../Skills/forms/CategorySelector.tsx | 2 +- .../components/Skills/tree/TreeToolbar.tsx | 6 +-- .../__tests__/connection.test.ts | 4 +- .../src/hooks/Endpoint/useSelectorEffects.ts | 22 ++++++----- client/src/utils/presets.ts | 13 +------ e2e/fixtures/subagent-history.test.cjs | 2 +- .../scenarios/sidebar-single-scroll.spec.ts | 5 ++- e2e/specs/mock/usage.spec.ts | 8 ++-- packages/client/src/svgs/AssistantIcon.tsx | 2 +- .../client/src/svgs/StopGeneratingIcon.tsx | 2 +- .../src/utils/tenantBulkWrite.spec.ts | 2 +- scripts/merge-locize-download.mjs | 4 +- scripts/validate-locize-download.mjs | 5 ++- 42 files changed, 117 insertions(+), 154 deletions(-) delete mode 100644 client/src/components/SidePanel/data.tsx diff --git a/api/server/routes/search.js b/api/server/routes/search.js index 2cd2fc3534..bed437d00c 100644 --- a/api/server/routes/search.js +++ b/api/server/routes/search.js @@ -20,7 +20,7 @@ router.get('/enable', async function (req, res) { const { status } = await client.health(); return res.send(status === 'available'); - } catch (error) { + } catch { return res.send(false); } }); diff --git a/api/test/__mocks__/openid-client.js b/api/test/__mocks__/openid-client.js index 766d8a305d..7148ef0dd7 100644 --- a/api/test/__mocks__/openid-client.js +++ b/api/test/__mocks__/openid-client.js @@ -19,7 +19,7 @@ module.exports = { })), }), }, - Strategy: jest.fn().mockImplementation((options, verify) => { + Strategy: jest.fn().mockImplementation(() => { // Store verify to call it if needed, or just mock the strategy behavior return { name: 'openid-mock-strategy' }; }), diff --git a/client/babel.config.cjs b/client/babel.config.cjs index 270f18f1a0..459ded7205 100644 --- a/client/babel.config.cjs +++ b/client/babel.config.cjs @@ -5,7 +5,7 @@ babel is used for frontend unit testing */ module.exports = { presets: [ - ['@babel/preset-env', { 'targets': { 'node': 'current' } }], //compiling ES2015+ syntax + ['@babel/preset-env', { targets: { node: 'current' } }], //compiling ES2015+ syntax ['@babel/preset-react', { runtime: 'automatic' }], '@babel/preset-typescript', ], @@ -21,8 +21,8 @@ module.exports = { [ 'babel-plugin-root-import', { - 'rootPathPrefix': '~/', - 'rootPathSuffix': './src', + rootPathPrefix: '~/', + rootPathSuffix: './src', }, ], ], diff --git a/client/src/components/Chat/Input/TextareaHeader.tsx b/client/src/components/Chat/Input/TextareaHeader.tsx index 00ba6e4651..41916b6bc7 100644 --- a/client/src/components/Chat/Input/TextareaHeader.tsx +++ b/client/src/components/Chat/Input/TextareaHeader.tsx @@ -14,7 +14,7 @@ export default memo(function TextareaHeader({ return null; } return ( -
+
); diff --git a/client/src/components/Chat/Menus/Endpoints/components/SpecDescription.tsx b/client/src/components/Chat/Menus/Endpoints/components/SpecDescription.tsx index b67395380a..e828572a3f 100644 --- a/client/src/components/Chat/Menus/Endpoints/components/SpecDescription.tsx +++ b/client/src/components/Chat/Menus/Endpoints/components/SpecDescription.tsx @@ -20,12 +20,12 @@ export default function SpecDescription({ description }: SpecDescriptionProps) { } if (!description.trim().startsWith('<')) { - return {description}; + return {description}; } return ( ); diff --git a/client/src/components/Chat/Menus/UI/MenuSeparator.tsx b/client/src/components/Chat/Menus/UI/MenuSeparator.tsx index d4f6f09a5a..4203ecf0f4 100644 --- a/client/src/components/Chat/Menus/UI/MenuSeparator.tsx +++ b/client/src/components/Chat/Menus/UI/MenuSeparator.tsx @@ -4,7 +4,7 @@ const MenuSeparator: FC = () => (
); diff --git a/client/src/components/Chat/Messages/Content/MemoryInfo.tsx b/client/src/components/Chat/Messages/Content/MemoryInfo.tsx index c81d02f895..2c0ec8cb82 100644 --- a/client/src/components/Chat/Messages/Content/MemoryInfo.tsx +++ b/client/src/components/Chat/Messages/Content/MemoryInfo.tsx @@ -52,10 +52,10 @@ export default function MemoryInfo({ memoryArtifacts }: { memoryArtifacts: Memor
{updatedMemories.map((artifact) => (
-
+
{artifact.key}
-
{artifact.value}
+
{artifact.value}
))}
@@ -65,10 +65,10 @@ export default function MemoryInfo({ memoryArtifacts }: { memoryArtifacts: Memor
{deletedMemories.map((artifact) => (
-
+
{artifact.key}
-
+
{localize('com_ui_memory_deleted')}
@@ -78,7 +78,7 @@ export default function MemoryInfo({ memoryArtifacts }: { memoryArtifacts: Memor {errorMessages.length > 0 && (
-

+

{localize('com_ui_memory_storage_full')}

diff --git a/client/src/components/Endpoints/Settings/OptionHover.tsx b/client/src/components/Endpoints/Settings/OptionHover.tsx index 47dea5611e..8f65bc9647 100644 --- a/client/src/components/Endpoints/Settings/OptionHover.tsx +++ b/client/src/components/Endpoints/Settings/OptionHover.tsx @@ -48,7 +48,7 @@ function OptionHover({ endpoint, type, side }: TOptionHoverProps) {
-

{localize(text)}

+

{localize(text)}

diff --git a/client/src/components/Input/SetKeyDialog/HelpText.tsx b/client/src/components/Input/SetKeyDialog/HelpText.tsx index 5e83d811f6..51470696ca 100644 --- a/client/src/components/Input/SetKeyDialog/HelpText.tsx +++ b/client/src/components/Input/SetKeyDialog/HelpText.tsx @@ -7,7 +7,7 @@ function HelpText({ endpoint }: { endpoint: string }) { const textMap = { [EModelEndpoint.google]: ( <> - + {localize('com_endpoint_config_google_service_key')} {': '} {localize('com_endpoint_config_key_google_need_to')}{' '} @@ -31,7 +31,7 @@ function HelpText({ endpoint }: { endpoint: string }) { {'. '} {localize('com_endpoint_config_key_google_vertex_api_role')} - + {localize('com_endpoint_config_google_api_key')} {': '} {localize('com_endpoint_config_google_api_info')}{' '} diff --git a/client/src/components/MCP/MCPConfigDialog.tsx b/client/src/components/MCP/MCPConfigDialog.tsx index 05ec5982c5..7c74f04172 100644 --- a/client/src/components/MCP/MCPConfigDialog.tsx +++ b/client/src/components/MCP/MCPConfigDialog.tsx @@ -91,7 +91,7 @@ export default function MCPConfigDialog({ // Connecting: blue (in progress) if (connectionState === 'connecting') { return ( -
+
{localize('com_ui_connecting')}
@@ -103,7 +103,7 @@ export default function MCPConfigDialog({ if (requiresOAuth) { // Needs OAuth: amber (requires action) return ( -
+
@@ -111,7 +111,7 @@ export default function MCPConfigDialog({ } // Simply disconnected: gray (neutral) return ( -
+
@@ -121,7 +121,7 @@ export default function MCPConfigDialog({ // Error: red if (connectionState === 'error') { return ( -
+
@@ -131,8 +131,8 @@ export default function MCPConfigDialog({ // Connected: green if (connectionState === 'connected') { return ( -
-
+
+
{localize('com_ui_active')}
); diff --git a/client/src/components/MCPUIResource/MCPUIResource.tsx b/client/src/components/MCPUIResource/MCPUIResource.tsx index 3aec3cba14..418d1224c9 100644 --- a/client/src/components/MCPUIResource/MCPUIResource.tsx +++ b/client/src/components/MCPUIResource/MCPUIResource.tsx @@ -26,7 +26,7 @@ export function MCPUIResource(props: MCPUIResourceProps) { if (!uiResource) { return ( - + {localize('com_ui_ui_resource_not_found', { 0: resourceId ?? '', })} @@ -53,7 +53,7 @@ export function MCPUIResource(props: MCPUIResourceProps) { } catch (error) { console.error('Error rendering UI resource:', error); return ( - + {localize('com_ui_ui_resource_error', { 0: uiResource.name || resourceId })} ); diff --git a/client/src/components/Messages/Content/Mermaid/ZoomControls.tsx b/client/src/components/Messages/Content/Mermaid/ZoomControls.tsx index 519b70c975..33bbf33b6b 100644 --- a/client/src/components/Messages/Content/Mermaid/ZoomControls.tsx +++ b/client/src/components/Messages/Content/Mermaid/ZoomControls.tsx @@ -52,7 +52,7 @@ const ZoomControls: React.FC = memo( return (
@@ -65,7 +65,7 @@ const ZoomControls: React.FC = memo( > - + {Math.round(zoom * 100)}% -
+
-
+
diff --git a/client/src/components/Nav/SettingsTabs/ApiKeys/Create.tsx b/client/src/components/Nav/SettingsTabs/ApiKeys/Create.tsx index 2cb0d7ae7b..910883732b 100644 --- a/client/src/components/Nav/SettingsTabs/ApiKeys/Create.tsx +++ b/client/src/components/Nav/SettingsTabs/ApiKeys/Create.tsx @@ -63,7 +63,7 @@ export default function Create({ onCreated, onCancel }: CreateProps) { placeholder={localize('com_ui_api_key_name_placeholder')} /> {nameError && ( - )} @@ -80,7 +80,7 @@ export default function Create({ onCreated, onCancel }: CreateProps) { label: localize(labelKey), }))} /> -

+

{expiresAt == null ? localize('com_ui_api_key_no_expiration') : localize('com_ui_api_key_expires_on', { 0: formatDate(expiresAt) })} diff --git a/client/src/components/Nav/SettingsTabs/ApiKeys/Reveal.tsx b/client/src/components/Nav/SettingsTabs/ApiKeys/Reveal.tsx index 62347e6360..3043196add 100644 --- a/client/src/components/Nav/SettingsTabs/ApiKeys/Reveal.tsx +++ b/client/src/components/Nav/SettingsTabs/ApiKeys/Reveal.tsx @@ -17,9 +17,9 @@ export default function Reveal({ createdKey, onDone }: RevealProps) { return (

-
-
{nothingToSpawn && ( -

+

diff --git a/client/src/components/SidePanel/Agents/DuplicateAgent.tsx b/client/src/components/SidePanel/Agents/DuplicateAgent.tsx index 10ea3febc4..1af518f710 100644 --- a/client/src/components/SidePanel/Agents/DuplicateAgent.tsx +++ b/client/src/components/SidePanel/Agents/DuplicateAgent.tsx @@ -44,7 +44,7 @@ export default function DuplicateAgent({ agent_id }: { agent_id: string }) { type="button" onClick={handleDuplicate} > -
+
diff --git a/client/src/components/SidePanel/Agents/SectionHeader.tsx b/client/src/components/SidePanel/Agents/SectionHeader.tsx index 5bd2497051..52d51b96aa 100644 --- a/client/src/components/SidePanel/Agents/SectionHeader.tsx +++ b/client/src/components/SidePanel/Agents/SectionHeader.tsx @@ -3,9 +3,9 @@ import { memo } from 'react'; function SectionHeader({ title, info }: { title: string; info: string }) { return (
-

{title}

-

{info}

-