From 46b529a86ae8750bae3b9c366b1641de33be8ebd Mon Sep 17 00:00:00 2001
From: UnicronBE <timothy.look@gmail.com>
Date: Fri, 10 Apr 2026 00:45:54 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=93=A9=20fix:=20Restore=20Primary=20Actio?=
 =?UTF-8?q?n=20Button=20Visibility=20in=20Light=20Mode=20(#12591)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The default <Button> variant (bg-primary / text-primary-foreground)
renders invisible in light mode on the Agent Marketplace 'Start Chat'
button and the Grant Access dialog 'Save Changes' button, making these
primary actions undiscoverable without hovering.

Switch these three affirmative-action buttons to variant='submit',
which uses the hardcoded 'bg-surface-submit text-white' combination
already defined in the Button component specifically to avoid the
contrast issues of the default variant (see the comment above the
'submit' variant in packages/client/src/components/Button.tsx).

No visual change in dark mode; in light mode the buttons now render
as the green submit color with white text, matching the semantic
intent of the action.

Co-authored-by: Timothy Look <timothy.look@pmv.eu>
---
 client/src/components/Agents/AgentDetail.tsx               | 7 ++++++-
 client/src/components/Agents/AgentDetailContent.tsx        | 7 ++++++-
 client/src/components/Sharing/GenericGrantAccessDialog.tsx | 1 +
 3 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/client/src/components/Agents/AgentDetail.tsx b/client/src/components/Agents/AgentDetail.tsx
index 1820eed8b9..4f71bb114f 100644
--- a/client/src/components/Agents/AgentDetail.tsx
+++ b/client/src/components/Agents/AgentDetail.tsx
@@ -183,7 +183,12 @@ const AgentDetail: React.FC<AgentDetailProps> = ({ agent, isOpen, onClose }) =>
           >
             <Link className="h-4 w-4" aria-hidden="true" />
           </Button>
-          <Button className="w-full max-w-xs" onClick={handleStartChat} disabled={!agent}>
+          <Button
+            variant="submit"
+            className="w-full max-w-xs"
+            onClick={handleStartChat}
+            disabled={!agent}
+          >
             {localize('com_agents_start_chat')}
           </Button>
         </div>
diff --git a/client/src/components/Agents/AgentDetailContent.tsx b/client/src/components/Agents/AgentDetailContent.tsx
index 1e06d8230f..7a2a95401d 100644
--- a/client/src/components/Agents/AgentDetailContent.tsx
+++ b/client/src/components/Agents/AgentDetailContent.tsx
@@ -181,7 +181,12 @@ const AgentDetailContent: React.FC<AgentDetailContentProps> = ({ agent }) => {
         >
           <Link className="h-4 w-4" aria-hidden="true" />
         </Button>
-        <Button className="w-full max-w-xs" onClick={handleStartChat} disabled={!agent}>
+        <Button
+          variant="submit"
+          className="w-full max-w-xs"
+          onClick={handleStartChat}
+          disabled={!agent}
+        >
           {localize('com_agents_start_chat')}
         </Button>
       </div>
diff --git a/client/src/components/Sharing/GenericGrantAccessDialog.tsx b/client/src/components/Sharing/GenericGrantAccessDialog.tsx
index d9270ef2d3..ce7fdbdc14 100644
--- a/client/src/components/Sharing/GenericGrantAccessDialog.tsx
+++ b/client/src/components/Sharing/GenericGrantAccessDialog.tsx
@@ -401,6 +401,7 @@ export default function GenericGrantAccessDialog({
                 </Button>
               </OGDialogClose>
               <Button
+                variant="submit"
                 onClick={handleSave}
                 disabled={
                   updatePermissionsMutation.isLoading ||