From 3cab71c48a131de085d3567df28e330ed2faa966 Mon Sep 17 00:00:00 2001 From: James Todaro <30529065+jtodaroii@users.noreply.github.com> Date: Wed, 9 Sep 2026 14:50:57 -0400 Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=B7=20ci:=20Await=20durable=20finaliza?= =?UTF-8?q?tion=20in=20conversation-management=20mock=20e2e=20(#15791)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - send each turn through sendMessageAndWaitForCompletion so the composer is unlocked before the next Enter - give the three tests explicit timeouts, matching the chat.spec.ts budgets from #14740 --- e2e/specs/mock/conversation-management.spec.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/e2e/specs/mock/conversation-management.spec.ts b/e2e/specs/mock/conversation-management.spec.ts index 1953b45117..80869a16be 100644 --- a/e2e/specs/mock/conversation-management.spec.ts +++ b/e2e/specs/mock/conversation-management.spec.ts @@ -7,7 +7,7 @@ import { replyPrompt, replyText, selectMockEndpoint, - sendMessage, + sendMessageAndWaitForCompletion, } from './helpers'; const firstConversation = (page: Page) => page.getByTestId('convo-item').first(); @@ -24,7 +24,7 @@ async function openMockChat(page: Page) { async function sendAndExpectReply(page: Page, label: string) { const prompt = replyPrompt(label); const reply = replyText(label); - const response = await sendMessage(page, prompt); + const response = await sendMessageAndWaitForCompletion(page, prompt); expect(response.ok()).toBeTruthy(); await expect(messagesView(page).getByText(prompt)).toBeVisible(); await expect(messagesView(page).getByText(reply)).toBeVisible(); @@ -48,6 +48,7 @@ async function renameConversation(page: Page, conversation: Locator, title: stri test.describe('conversation management', () => { test('loads a past sidebar conversation with its message history', async ({ page }) => { + test.setTimeout(90000); const firstLabel = uniqueLabel('sidebar-history-first'); const secondLabel = uniqueLabel('sidebar-history-second'); @@ -73,6 +74,7 @@ test.describe('conversation management', () => { }); test('renames a conversation from the sidebar', async ({ page }) => { + test.setTimeout(60000); const label = uniqueLabel('sidebar-rename'); const renamedTitle = `Renamed ${label}`; @@ -87,6 +89,7 @@ test.describe('conversation management', () => { test('deletes a conversation, clears its messages, and blocks direct URL access', async ({ page, }) => { + test.setTimeout(60000); const label = uniqueLabel('sidebar-delete'); const renamedTitle = `Delete ${label}`;