From 2ea44e0d677be14cf12afd2c6301b9e35dfa7900 Mon Sep 17 00:00:00 2001 From: Marco Beretta <81851188+berry-13@users.noreply.github.com> Date: Sat, 3 Oct 2026 15:47:53 +0200 Subject: [PATCH] fix: Layer Settings Dialog Popovers Above Its Panel (#16720) The Settings dialog is a Headless UI panel at z-50, not an OGDialog, so it set no dialog depth and its Select lists kept their z-40 layer, opening invisibly behind the panel. A new DialogLayer counts it as one dialog level, so popovers inside it take the depth-aware z-index they get inside an OGDialog. --- client/src/components/Nav/Settings/Dialog.tsx | 68 ++++++++++--------- .../mock/scenarios/nested-popovers.spec.ts | 49 ++++++++++++- .../client/src/components/OriginalDialog.tsx | 9 +++ .../__tests__/popoverLayering.spec.tsx | 16 ++++- 4 files changed, 106 insertions(+), 36 deletions(-) diff --git a/client/src/components/Nav/Settings/Dialog.tsx b/client/src/components/Nav/Settings/Dialog.tsx index 7437da1c1b..6c12c1b545 100644 --- a/client/src/components/Nav/Settings/Dialog.tsx +++ b/client/src/components/Nav/Settings/Dialog.tsx @@ -2,7 +2,7 @@ import { useState } from 'react'; import * as Tabs from '@radix-ui/react-tabs'; import { X, ChevronLeft } from 'lucide-react'; import { SettingsTabValues } from 'librechat-data-provider'; -import { Button, useMediaQuery, DIALOG_SCRIM_CLASS } from '@librechat/client'; +import { Button, DialogLayer, useMediaQuery, DIALOG_SCRIM_CLASS } from '@librechat/client'; import { Dialog, DialogPanel, DialogTitle, Transition, TransitionChild } from '@headlessui/react'; import type { TDialogProps } from '~/common'; import type { SettingsTab } from './types'; @@ -101,38 +101,42 @@ export default function SettingsDialog({ open, onOpenChange }: TDialogProps) {