From 2c6db6bf737533f59a6ede54bc91db1fcdc7d864 Mon Sep 17 00:00:00 2001 From: Danny Avila Date: Thu, 18 Jun 2026 22:25:54 -0400 Subject: [PATCH] =?UTF-8?q?=F0=9F=AA=9E=20fix:=20Match=20Prompt=20Cache=20?= =?UTF-8?q?TTL=20Control=20to=20Region=20Combobox=20Styling=20(#13839)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Prompt Cache Duration control used `component: 'dropdown'` (DynamicDropdown → SelectDropDown), which renders with a different trigger style than the sibling Region selector and expands its options inline (headless-ui Listbox) — causing a visual mismatch and layout shift in the parameters panel. Switch both the Anthropic and Bedrock promptCacheTtl definitions to `component: 'combobox'` (DynamicCombobox → ControlCombobox), the same component Region uses: matching rounded trigger styling, an Ariakit popover (portal, no layout shift), and — as a bonus — it persists selections via setOption on custom endpoints (DynamicDropdown's custom branch is a no-op TODO). Renames the placeholder fields to the combobox's selectPlaceholder/selectPlaceholderCode. --- packages/data-provider/src/parameterSettings.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/data-provider/src/parameterSettings.ts b/packages/data-provider/src/parameterSettings.ts index 39ff99d7c9..bb746fbf86 100644 --- a/packages/data-provider/src/parameterSettings.ts +++ b/packages/data-provider/src/parameterSettings.ts @@ -415,11 +415,11 @@ const anthropic: Record = { type: 'enum', default: anthropicSettings.promptCacheTtl.default, options: ['5m', '1h'], - component: 'dropdown', + component: 'combobox', optionType: 'conversation', showDefault: false, - placeholder: 'com_endpoint_prompt_cache_ttl_default', - placeholderCode: true, + selectPlaceholder: 'com_endpoint_prompt_cache_ttl_default', + selectPlaceholderCode: true, columnSpan: 2, }, thinking: { @@ -577,11 +577,11 @@ const bedrock: Record = { type: 'enum', default: undefined, options: ['5m', '1h'], - component: 'dropdown', + component: 'combobox', optionType: 'conversation', showDefault: false, - placeholder: 'com_endpoint_prompt_cache_ttl_default', - placeholderCode: true, + selectPlaceholder: 'com_endpoint_prompt_cache_ttl_default', + selectPlaceholderCode: true, columnSpan: 2, }, reasoning_effort: {