CERBERUS/LibreChat
1
0
Fork 0
mirror of https://github.com/danny-avila/LibreChat.git synced 2026-08-04 14:57:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

🔌 fix: Detach Label Abort Listeners Even Without Claims

Browse source 
A segment with labels enabled can end without a single claim (text-only, or handoff batches, which skip labels); the early return in settleActivityLabels skipped the detach added for HITL listener accumulation. The detach now runs on both paths.
This commit is contained in:
Danny Avila 2026-07-28 17:00:19 -04:00
parent 0e5c6e4f60
commit 1c43c0e440
1 changed files with 12 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

18
api/server/controllers/agents/client.js
View file

@ -645,8 +645,19 @@ class AgentClient extends BaseClient {
* timeout the label scope is closed and its abort controller fired, so a
* straggler cannot mutate the saved response or emit into a dead job. */
async settleActivityLabels(timeoutMs = 3000) {
/** Detached even when nothing settled: the wiring attaches its abort
* listener at BUILD time, and a segment can end without a single claim
* (text-only, or handoff batches, which skip labels) — the early
* return below would otherwise leave that listener accumulating across
* HITL approval cycles on the shared job signal. Idempotent. */
const detachScopeListeners = () => {
for (const scope of this.activityLabelScopes ?? []) {
scope.detach?.();
}
};
const pending = this.pendingActivityLabelFills;
if (!pending || pending.length === 0) {
detachScopeListeners();
return;
}
this.pendingActivityLabelFills = [];
@ -658,12 +669,7 @@ class AgentClient extends BaseClient {
scope.abort.abort();
}
});
/** Settled either way — the abort listener has no remaining work, and
* leaving it attached across HITL approval cycles accumulates dead
* closures on the shared job signal. Idempotent on double settle. */
for (const scope of this.activityLabelScopes ?? []) {
scope.detach?.();
}
detachScopeListeners();
}
/**