refactor: Presets, Skills Motion and Model Selector Polish (#14953)

* refactor: presets, skills motion and model selector polish

Four surfaces that had drifted from the rest of the app, plus the CI
fragility that surfaced while getting them green.

Two were functional bugs rather than styling:

Keyboard focus was invisible in the model selector. The highlight rule
existed and the background was painted, but it used surface-secondary and
the menu sits on bg-presentation, which resolve to the same value in dark
and to within 3/255 in light, so only the thin indicator bar ever showed.
Keyboard focus now uses the same surface a pointer gets.

Importing a malformed preset raised com_ui_upload_invalid, which talks
about image size limits, and FileUpload's JSON.parse had nothing catching
it at that call site. The overflow menu owns the input and reports the
existing preset import error instead.

The rest is polish: preset surfaces use the theme radius roles rather than
raw values; the edit dialog stops nesting a fixed 350px scroll box inside
an already scrolling dialog and pins its title and actions, with the
endpoint picker moved to ControlCombobox and kept out of any clipping
ancestor; Clear all and Import move into a three-dots menu matching the
conversation row; the Skills sections and pinned chats adopt the Collapse
that Projects already used; the rendered/source toggle slides between
states, is extracted rather than duplicated, and gains the accessible name
and RTL mirroring it lacked; the header toggle loses its fill and the
mobile new chat button hides when you are already in a new chat.

The CI changes are unrelated to the UI but blocked it: the MCP and Redis
cache jobs installed Redis with a bare apt-get and lost a race against the
runner's own apt-daily work, failing four times and once hanging for 30
minutes. They now stop that background work and wait for the lock.
DPkg::Lock::Timeout alone does not help, since it covers the dpkg frontend
lock and not the lists lock.

* refactor: move the section label appearance into the Label primitive

The preset dialog reached into the agent panel's private `Advanced/ui` for
its field eyebrow, so an agent-only refactor could change the dialog.

Give the shared `Label` a `section` variant and export the recipe for the
agent id row, which heads its value on a span and must not inherit the
label's block layout. Each variant carries its own size, leading and color:
the recipe output reaches that span unmerged, and a font size declared after
`leading-none` drops it.

* fix: derive the mobile new chat action from the route

The context conversation still holds the previous chat for a render after a
history or link navigation, a lag ChatView already guards against, so the
action could show on /c/new or hide while an existing chat loaded.

* style: sort imports in the touched files

* fix: return focus to the menu item after the clear dialog

The dialog is controlled and has no trigger, so Radix restored focus to
whatever held it when the content mounted, the menu's own focus trap, and a
keyboard user was left on the document. The menu stays open behind the
dialog, so the invoking item is still there to take focus back.

* fix: fall back to the trigger when clearing removes the invoking item

Confirming empties the presets optimistically, so React commits the removed
menu item together with the dialog close and the saved invoker is already
disconnected when focus is handed back.

---------

Co-authored-by: Danny Avila <danny@librechat.ai>
This commit is contained in:
Marco Beretta 2026-08-19 21:49:47 +02:00 committed by GitHub
parent f431b01d1f
commit 16e4d14191
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
22 changed files with 544 additions and 227 deletions

View file

@ -45,9 +45,29 @@ jobs:
node-version: '24.16.0'
- name: Install Redis tools
timeout-minutes: 10
run: |
sudo apt-get update
sudo apt-get install -y redis-server redis-tools
# Same runner apt contention that broke the MCP job in
# playwright-mock.yml: apt-daily/unattended-upgrades hold
# /var/lib/apt/lists/lock at boot. Without a step timeout this hung
# until the job-level one fired, taking the whole leg with it.
sudo systemctl stop apt-daily.service apt-daily-upgrade.service \
unattended-upgrades.service 2>/dev/null || true
sudo systemctl kill --kill-who=all apt-daily.service \
apt-daily-upgrade.service 2>/dev/null || true
apt_with_lock_wait() {
for attempt in $(seq 1 30); do
if sudo apt-get -o DPkg::Lock::Timeout=60 "$@"; then
return 0
fi
echo "apt-get $1 could not take the lock (attempt ${attempt}/30), retrying"
sleep 10
done
return 1
}
apt_with_lock_wait update
apt_with_lock_wait install -y redis-server redis-tools
- name: Start Single Redis Instance
run: |