From 0b80ea5ebf537800e1f25cae5baa5706dbd700dc Mon Sep 17 00:00:00 2001 From: Marco Beretta <81851188+berry-13@users.noreply.github.com> Date: Tue, 29 Sep 2026 19:17:33 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=AB=A7=20fix:=20Paint=20Chat=20Surfaces?= =?UTF-8?q?=20From=20Theme=20Roles=20(#16483)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix: Paint Chat Surfaces From Theme Roles The code window header and skill output panel stop repainting their surface-secondary container with a per-mode fill that matched it in every bundled theme, the drag-and-drop backdrop becomes the theme scrim, the OpenAI file-source chip takes the primary surface, and the banner drops a stopless dark gradient. ActionIcon, RetrievalIcon, WrenchIcon and the message ProgressCircle had no importers and carried fixed Lottie colours, so they are removed. The media, artwork and exported-document colours that stay fixed are recorded in the theme allowlist. * fix: Keep the Drag-and-Drop Backdrop Black Until Scrim Opacity Is a Role The theme scrim is gray in default light, so at the same alpha it dimmed the page less than the black backdrop it replaced. The backdrop keeps its original colour and the allowlist records the scrim-opacity role it waits on. * test: Cover the Code Window Header Showing Its Panel Surface * test: Exercise the Code Window Header Through a File-Authoring Card The mock code interpreter exposes bash_tool, whose card has its own header; a skill file created by the model opens the file-authoring card that renders CodeWindowHeader. * fix: Keep the OpenAI File-Source Chip's Dark Opacity The chip composites over the file's own preview, where surface-primary at 75% darkened it against the shipped black at 65%. It keeps its colours and joins the code-execution badge in the allowlist as a media overlay. --- client/src/components/Banners/Banner.tsx | 6 +- .../Chat/Messages/Content/ActionIcon.tsx | 172 ------------------ .../Content/Parts/CodeWindowHeader.tsx | 2 +- .../Chat/Messages/Content/Parts/SkillCall.tsx | 10 +- .../Chat/Messages/Content/ProgressCircle.tsx | 38 ---- .../Chat/Messages/Content/RetrievalIcon.tsx | 80 -------- .../Chat/Messages/Content/WrenchIcon.tsx | 49 ----- .../mock/scenarios/code-window-header.spec.ts | 75 ++++++++ eslint-suppressions.json | 29 --- packages/client/src/theme/allowlist.md | 12 ++ 10 files changed, 96 insertions(+), 377 deletions(-) delete mode 100644 client/src/components/Chat/Messages/Content/ActionIcon.tsx delete mode 100644 client/src/components/Chat/Messages/Content/ProgressCircle.tsx delete mode 100644 client/src/components/Chat/Messages/Content/RetrievalIcon.tsx delete mode 100644 client/src/components/Chat/Messages/Content/WrenchIcon.tsx create mode 100644 e2e/specs/mock/scenarios/code-window-header.spec.ts diff --git a/client/src/components/Banners/Banner.tsx b/client/src/components/Banners/Banner.tsx index 78d840e81b..7fa078d513 100644 --- a/client/src/components/Banners/Banner.tsx +++ b/client/src/components/Banners/Banner.tsx @@ -58,11 +58,11 @@ export const Banner = ({ onHeightChange }: { onHeightChange?: (height: number) = return (
-
diff --git a/client/src/components/Chat/Messages/Content/ActionIcon.tsx b/client/src/components/Chat/Messages/Content/ActionIcon.tsx deleted file mode 100644 index 2c6ee4465f..0000000000 --- a/client/src/components/Chat/Messages/Content/ActionIcon.tsx +++ /dev/null @@ -1,172 +0,0 @@ -export default function ActionIcon() { - return ( - - - - - - - - - - - - - - - - - - - - - - - - - {/* eslint-disable-next-line react/no-unknown-property */} - - - - - - - - - - - - - - - - - - - - - - - {/* eslint-disable-next-line react/no-unknown-property */} - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - ); -} diff --git a/client/src/components/Chat/Messages/Content/Parts/CodeWindowHeader.tsx b/client/src/components/Chat/Messages/Content/Parts/CodeWindowHeader.tsx index 93ee1851f2..d3ab56c4cf 100644 --- a/client/src/components/Chat/Messages/Content/Parts/CodeWindowHeader.tsx +++ b/client/src/components/Chat/Messages/Content/Parts/CodeWindowHeader.tsx @@ -25,7 +25,7 @@ export default function CodeWindowHeader({ language, code, diffStats }: CodeWind }, [code]); return ( -
+
{language} diff --git a/client/src/components/Chat/Messages/Content/Parts/SkillCall.tsx b/client/src/components/Chat/Messages/Content/Parts/SkillCall.tsx index 8a58ad08dc..0e95897bf9 100644 --- a/client/src/components/Chat/Messages/Content/Parts/SkillCall.tsx +++ b/client/src/components/Chat/Messages/Content/Parts/SkillCall.tsx @@ -63,7 +63,7 @@ export default function SkillCall({ icon={