3x-ui/internal/util
sdhfsl d440c2b932
fix(panel): accept 2FA codes from adjacent TOTP windows (#6546)
* fix(panel): accept 2FA codes from adjacent TOTP windows

CheckUser compared only gotp.Now(), so a code submitted at the end of
its 30s window (or with slight client/server clock drift) failed with
'invalid 2fa code', while the immediate retry in the next window
succeeded. Accept current +/-1 window, the standard TOTP skew
tolerance.

Fixes MHSanaei/3x-ui#6535

* fix(panel): share TOTP skew tolerance with VerifyTwoFactorCode

Move the +/-1 window helper to internal/util/totp so both 2FA
acceptance points use it: login (CheckUser) and disable/rebind plus
username/password changes (VerifyTwoFactorCode). Also shrink comments
to the 2-line house rule and anchor the unit test mid-window to avoid
a step-boundary flake.

Addresses review on #6546 (MEDIUM + 2 LOWs).

---------

Co-authored-by: sdhfsl <sdhfsl@users.noreply.github.com>
2026-09-15 15:42:30 +03:00
..
common Add remote routing URL support (#6168) 2026-08-18 16:02:11 +02:00
crypto feat(node): node hardening — mTLS, hashed+zstd reconcile transport, per-node net metrics (#5382) 2026-06-16 12:19:33 +02:00
json_util refactor: focused service files, leaf subpackages, and an internal/ layout (#5167) 2026-06-10 15:19:22 +02:00
ldap feat: ldap skip tls verify (#5637) 2026-06-28 18:10:38 +02:00
link fix(link): restore mKCP seed and headerType on share-link import (#6480) 2026-09-13 22:28:13 +02:00
netproxy Test-quality audit: fix 2 prod bugs, strengthen weak tests, add mutation/fuzz/CI tooling (#5345) 2026-06-15 15:17:03 +02:00
netsafe fix(netsafe): classify IPv6 transition and CGNAT ranges as internal 2026-08-19 19:37:14 +02:00
random style: adopt golangci-lint v2 and resolve all findings 2026-06-27 15:42:22 +02:00
reflect_util refactor: focused service files, leaf subpackages, and an internal/ layout (#5167) 2026-06-10 15:19:22 +02:00
sys fix(lint): use errors.Is for io.EOF comparison in sys_linux 2026-06-27 16:38:07 +02:00
totp fix(panel): accept 2FA codes from adjacent TOTP windows (#6546) 2026-09-15 15:42:30 +03:00
wirecodec feat(node): node hardening — mTLS, hashed+zstd reconcile transport, per-node net metrics (#5382) 2026-06-16 12:19:33 +02:00
wireguard feat(wireguard): multi-client support 2026-06-28 00:44:38 +02:00